[codex] Configure canonical TaskNote path generation#1867
Draft
johnyoonh wants to merge 2 commits intocallumalpass:mainfrom
Draft
[codex] Configure canonical TaskNote path generation#1867johnyoonh wants to merge 2 commits intocallumalpass:mainfrom
johnyoonh wants to merge 2 commits intocallumalpass:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes inline TaskNote conversion when a task already contains a canonical
[[...|note]]link, then adds configuration for the generated canonical path style.What changed
[[...|note]]links as the target TaskNote path during inline conversion.snake_caseslugs.Why
Previously, canonical inline links could be ignored or regenerated from parsed/NLP text, which produced incorrect paths such as
skill review duration.mdfromMonthly skill review. When the expected file already existed, conversion could fail withFile already existsor create a duplicate path instead of offering a deliberate reuse path.Validation
npm test -- --runTestsByPath tests/unit/utils/taskTitleFormatter.test.ts tests/unit/utils/filenameGenerator.title-style.test.ts tests/unit/services/InstantTaskConvertService.test.ts tests/unit/services/TaskService.test.tsnpm run typechecknpm run build:test/Applications/Obsidian.app/Contents/MacOS/obsidian-cli plugin:reload id=tasknotes vault=test/Applications/Obsidian.app/Contents/MacOS/obsidian-cli dev:errors vault=testdev:errorsonly reported the pre-existing indexing error for99_meta/reminders/lists/automation.md.