test: cover git diff mode#14
Merged
Merged
Conversation
Add real temporary Git repository coverage for impact and run base/head selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR adds regression coverage for Sniffler's Git diff mode. The previous tests covered base/head selection through a mocked diff provider, but they did not prove that the default
git diff --name-only <base> <head>path works in a real repository.How does it work?
The new Vitest integration test creates a temporary Sniffler project inside a temporary Git repository, commits a baseline, changes both an impacted file and an unrelated file, and then runs the CLI with real
--baseand--headSHAs. It verifies bothimpactJSON output andrunmode runner arguments while cleaning up the temporary repository after each test.Why is this useful?
This gives maintainers confidence that CI-style base/head workflows continue to work through the actual subprocess-backed Git path. It also guards against false positives by confirming that unrelated changed files are reported without selecting extra E2E tests.