Skip to content

fix: inline code styling and nested button violation in nav #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artus9033 merged 2 commits into from
Apr 7, 2026
Merged

fix: inline code styling and nested button violation in nav #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e54a3
fix: styling and hydration problems
artus9033 Apr 7, 2026
d48b0b6
chore: changeset version
artus9033 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/preset/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@callstack/rspress-preset",
"version": "0.6.1",
"version": "0.6.2",
"description": "Callstack preset for Rspress docs",
"author": "Jakub Romańczyk <jakub.romanczyk@callstack.com>",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/theme/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@callstack/rspress-theme",
"version": "0.6.1",
"version": "0.6.2",
"description": "Callstack theme for Rspress docs",
"author": "Jakub Romańczyk <jakub.romanczyk@callstack.com>",
"license": "MIT",
Expand Down
3 changes: 1 addition & 2 deletions packages/theme/src/styles/variables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@
--rp-c-text-2: var(--ck-text-secondary) !important;
--rp-c-text-3: var(--ck-text-tertiary) !important;
--rp-c-text-4: var(--ck-text-tertiary) !important;
--rp-c-text-code: var(--ck-accent) !important;
/* rspress brand colors */
--rp-c-brand: var(--ck-accent) !important;
--rp-c-brand-light: var(--ck-accent) !important;
Expand All @@ -129,7 +128,7 @@
--rp-code-title-bg: rgba(233, 231, 238, 1) !important;
--rp-code-block-bg: rgba(249, 248, 253, 1) !important;
/* rspress inline code colors */
/* --rp-c-text-code: var(--rp-c-text-1) !important; */
--rp-c-text-code: var(--rp-c-text-1) !important;
--rp-c-text-code-bg: var(--ck-border-secondary) !important;
/* rspress link colors */
--rp-c-link: var(--rp-c-text-1) !important;
Expand Down
8 changes: 5 additions & 3 deletions packages/theme/src/theme/components/switch-appearance/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,16 @@ export function SwitchAppearance({ onClick }: { onClick?: () => void }) {
const Icon = theme === 'dark' ? IconSun : IconMoon;

return (
<button
type="button"
// biome-ignore lint/a11y/useSemanticElements: this component is a nested button in mobile nav, which would cause a hydration error
<div
role="button"
tabIndex={0}
onClick={handleClick}
className="rspress-nav-appearance"
>
<div className="rp-p-1 rp-border rp-border-solid rp-border-gray-300 rp-text-gray-400 rp-cursor-pointer rp-rounded-md rp-transition-all rp-duration-300 rp-w-7 rp-h-7">
<Icon width="18" height="18" fill="currentColor" />
</div>
</button>
</div>
);
}
Loading