Duplicated react and react-native dependencies #914
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g used on peerDependencies (line 89) and its types being declared in devDependencies (line 76)
…ared in peerDependencies
Author
|
@satya164 could you review it for me, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem creating JS library and adding a simple component since its declaring react and react native into devDependecies as issue #912 (#912)
This PR remove/replace react and react-native from dev dependecies by their types once it should be used on peer dependecies only.
Summary
as issue #912
while creat-react-native-library -> JSLibrary, sample project breaks while creating any simple component since they use different types of react and react native reference. one for the library and anathoer for the example.
Test plan
create a JSLibrary template and add a simple component as suggest below:
