feat: add debug symbols workflow#756
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
a25068d to
073d0cb
Compare
Code reviewVerdict: significant issues — the headline Findings
Verified cleanNo command injection ( OverallGood architecture — clean parse/match/symbolicate separation, bounded search, well-normalized errors. But the flagship Generated by Claude Code |
073d0cb to
59095db
Compare
|
Holding merge readiness on this until real Apple verification is done. Fixture-backed tests and command-construction coverage are useful, but for this workflow we need an actual simulator/device crash artifact plus matching dSYM exercised end-to-end with Please add validation evidence with the exact commands, simulator/device identity, crash artifact + dSYM provenance, output path, and proof the symbolicated artifact was produced. Until then I no longer consider #756 merge-ready. |
59095db to
e03d5c4
Compare
Summary
Adds a narrow
agent-device debug symbolsworkflow for crash symbolication in the #694 native diagnostics rollout..ips,.crash, and log-style crash artifacts by matching UUIDs against local.dSYMbundles viadwarfdump --uuid, then runningatos.debugscoped to symbols/crash artifact space; logs, network, perf, record/trace, and React Native internals stay routed to existing commands.Refs #699
Refs #694
Touched files: 21.
Validation
Worker validation passed:
pnpm format.pnpm check:quick.pnpm check:unit: 249 unit files, 2333 tests, 8 smoke tests.pnpm build.git diff --check.Fixture-backed CLI evidence:
mapping.txt/ndk-stack/addr2lineexternal workflows.SkillGym case
debug-symbols-apple-crashwas added but not runnable in the sandbox because external runner approval was denied.Residual risk: no real simulator crash/dSYM artifact was generated in this sandbox; coverage is fixture-backed with command construction and artifact proof.