fix: use correct valid property in license check response (#26610)

[ousamabenyounes]

What does this PR do?

• Fixes [API v2] License validation bug: checkLicense checks data.status but API returns data.valid #26610

The checkLicense() method in DeploymentsService reads data.status from the Cal.com license API response, but the API actually returns { valid: boolean }. This causes the method to always return undefined (falsy), breaking API key authentication on all self-hosted instances with valid Enterprise licenses.

Root cause

// Before (broken) — reads non-existent property
type LicenseCheckResponse = { status: boolean };
return data.status; // always undefined

// After (fixed) — reads correct property
type LicenseCheckResponse = { valid: boolean };
return data.valid; // true or false as expected

The same bug affects both the fresh fetch path and the Redis cache read path.

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

1. Deploy API v2 on a self-hosted instance with a valid CALCOM_LICENSE_KEY
2. Create an API key from Settings > Security
3. Make a request: curl -H "Authorization: Bearer cal_xxx" -H "cal-api-version: 2024-08-13" https://your-domain/api/v2/bookings
4. Before fix: returns 401 "Invalid or missing CALCOM_LICENSE_KEY"
5. After fix: returns 200 with bookings data

Unit tests added covering:

• License API response with { valid: true } and { valid: false }
• Cached data path (Redis hit)
• e2e mode bypass
• Missing license key fallback to DB
• Redis caching of API response

Verification

• Baseline tests: 6819 pass, 0 failures
• Post-fix tests: no regressions
• New tests: 9 added (Jest), all pass
• Review agent: issue alignment verified

Files changed

File	Change
apps/api/v2/src/modules/deployments/deployments.service.ts	Fix LicenseCheckResponse type and property access from status to valid
apps/api/v2/src/modules/deployments/deployments.service.spec.ts	New: 9 unit tests for checkLicense()

Generated by Claude Code
Vibe coded by ousamabenyounes