[WIP] LSP integration#102
Draft
bjorkstromm wants to merge 1 commit intodevelopfrom
Draft
Conversation
Member
|
Yeah, I'll try and have a look. I was chatting to @madskristensen about this stuff this morning so I want to try and give it another crack with the more stable bits from O# and the more stable bits from the VS end as well. |
Member
|
Currently blocked running into OmniSharp/csharp-language-server-protocol#132. For my own reference, we still have a couple of big questions to sort out before we ship this:
|
Member
Author
|
@agc93 I’ve submitted a fix to OmniShatp here OmniSharp/omnisharp-roslyn#1503, once that’s merged, you can get the latest OmniSharp bits from the blob and try this out agan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gep13 or @agc93 anyone of you want to continue with this? The newer OmniSharp builds now has much more stable LSP implementation.