Skip to content

Update from upstream repo commandpost/commandpost-app@master#12

Open
backstroke-bot wants to merge 3304 commits into
cailyoung:masterfrom
CommandPost:master
Open

Update from upstream repo commandpost/commandpost-app@master#12
backstroke-bot wants to merge 3304 commits into
cailyoung:masterfrom
CommandPost:master

Conversation

@backstroke-bot

Copy link
Copy Markdown

Hello!

The upstream repository commandpost/commandpost-app@master has some new changes that aren't in this fork. So, here they are, ready to be merged! 🎉

If this pull request can be merged without conflict, you can publish your software with these new changes. Otherwise, fix any merge conflicts by clicking the Resolve Conflicts button.


If you like Backstroke, consider donating to help us pay for infrastructure here. Backstroke is a completely open source project that's free to use, but we survive on sponsorships and donations. Thanks for your support! Help out Backstroke.


Created by Backstroke (I'm a bot!)

latenitefilms and others added 30 commits March 2, 2023 11:59
1. Fix window titles broken from truncating
2. When using hint chars vimperator, use the parent app's file name as a fallback, in case the app's title starts with a utf8 char.
…on#3415)

* This should make no difference at all, but it seems mildly more correct

* Update sentry-cli and the commands used to upload dSYM files
* Update some NSWorkspace usage to avoid deprecated methods

* This call is deprecated and doesn't seem to be needed anyway

* Update a deprecated constant name

* Add LuaSking arg parsing to a method that was recently added

* Fix a CGImageRef leak

* Update RocketSocket to avoid a deprecated method
…use that rendered version in the HTML output template. Closes Hammerspoon#3217
… it, since we're still getting crash reports of the port being invalid
algal and others added 30 commits November 18, 2025 23:38
When hs.window:application() is called on a window whose process has
just terminated (initWithPid returns nil), the code must ensure the
return value is pushed onto the correct lua_State.

The bug occurred because:
1. The shared LuaSkin instance's .L field can be temporarily swapped
   by class-level logging (+[LuaSkin logError:...])
2. When app==nil, logError is called for the missing NSRunningApplication
3. If pushNSObject(nil) executes while .L points to a different state,
   the nil gets pushed onto the wrong Lua stack
4. The C function returns '1 result' to the caller's L, but that stack
   is empty, triggering: 'not enough elements in the stack' assertion

Fix: When app is nil, push nil directly to the caller's L using
lua_pushnil(L) instead of going through pushNSObject which uses the
mutable shared instance's .L.

Also add lua_settop(L, 0) to prevent leaking the receiver in coroutines
(matching the pattern used in other window methods).

Fixes intermittent crashes during window enumeration when iterating
over windows from recently-terminated applications.
This change allows calls to hs.menubar:setMenu() to update the menu
even if it is currently visible.

The original code would delete the old menu and set a new NSMenu instance
however macOS will not show a new menu while the old - now empty one - is
still open.
Sometimes an app generates an event just before dying/terminating

thus the event handler tries to retrieve the app of the PID
but it is no longer available. This patch avoids a crash
due to not finding the app for the given pid
- Updated copyright date.
- Turned on `UIDesignRequiresCompatibility` to fix Tahoe toolbars.
Add USB Product IDs and device matching for newer Elgato Stream Deck devices:
- Stream Deck Neo (0x009A) - 8 keys (4x2), uses Mini class
- Stream Deck Module 6 (0x00B8) - 6 keys (3x2), uses Mini class
- Stream Deck Module 15 (0x00B9) - 15 keys (5x3), uses MK2 class
- Stream Deck Module 32 (0x00BA) - 32 keys (8x4), uses XL class

Device PIDs from official Elgato HID documentation:
https://docs.elgato.com/streamdeck/hid/
- CommandPost will only launch if a paid and valid LateNite application is installed.
- We should check for Apple's code-signing, not LateNite's.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.