add knip and improve cursor rules#23
Merged
Corb3nik merged 4 commits intocaido-community:mainfrom Nov 26, 2025
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Corb3nik
reviewed
Nov 26, 2025
| "devDependencies": { | ||
| "@caido/sdk-backend": "^0.46.0" | ||
| "@caido/sdk-backend": "^0.46.0", | ||
| "vite": "6.0.11" |
Contributor
There was a problem hiding this comment.
Do you know why we need to add vite? Has the templates always been broken before?
Contributor
Author
There was a problem hiding this comment.
I added this because Knip would return this warning without the vite dep
Unlisted binaries (1)
vite packages/backend/package.json
| "@caido/eslint-config": "^0.5.0", | ||
| "@caido/tailwindcss": "0.0.1", | ||
| "@vitejs/plugin-vue": "5.2.1", | ||
| "eslint": "9.29.0", |
Contributor
There was a problem hiding this comment.
Same question regarding eslint.
Contributor
Author
There was a problem hiding this comment.
Similar thing here, added this because Knip would return this warning without it
Unlisted dependencies (1)
eslint eslint.config.mjs
Unlisted binaries (2)
eslint package.json
| "@caido-community/dev": "^0.1.3", | ||
| "@caido/eslint-config": "^0.5.0", | ||
| "typescript": "5.5.4" | ||
| "eslint": "9.29.0", |
Contributor
There was a problem hiding this comment.
Same question regarding eslint.
Contributor
Author
There was a problem hiding this comment.
Same thing here as in the last comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.