Commit returns 'None' on failed config with commit_error_dialog_dict set#25
Open
nights99 wants to merge 1 commit intocafykit:developfrom
Open
Commit returns 'None' on failed config with commit_error_dialog_dict set#25nights99 wants to merge 1 commit intocafykit:developfrom
nights99 wants to merge 1 commit intocafykit:developfrom
Conversation
…lt_error_marker in commit_error_dialog_dict. case is hit, but then .if alt_error_marker in output:. is not hit . in the case where there was a commit error which is not the 'One or more commits have occurred from other' error. If this path is hit, there is no .else. case, so no output is returned and also no exception raised . i.e. there.s no way to tell anything about the commit result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem comes when “if commit_error_dialog_dict is not None and alt_error_marker in commit_error_dialog_dict” case is hit, but then “if alt_error_marker in output:” is not hit – in the case where there was a commit error which is not the 'One or more commits have occurred from other' error.
If this path is hit, there is no ‘else’ case, so no output is returned and also no exception raised – i.e. there’s no way to tell anything about the commit result.