handle tlent_login if prompt is in config mode#35
Open
shreyashah wants to merge 1 commit intover_4.0.0from
Open
handle tlent_login if prompt is in config mode#35shreyashah wants to merge 1 commit intover_4.0.0from
shreyashah wants to merge 1 commit intover_4.0.0from
Conversation
Contributor
Author
|
Reports: allure.cisco.com/ws/shreyash-sjc/cafyinfra/cafykit/work/archive/test_console_20240603-095340_p3275248/reports/index.html Reports: allure.cisco.com/ws/shreyash-sjc/cafyinfra/cafykit/work/archive/test_console_20240603-094733_p3273248/reports/index.html |
shreyashah
changed the title
nishantupadhyay123
suggested changes
Jun 3, 2024
Comment on lines
+181
to
+189
|
|
||
| if re.search('RP/\d+/RP\d+/CPU\d+:\S*\)#$', output): | ||
| # To check if it is in the config prompt | ||
| # If yes, then write newline char, "clear" and "end" to clear any stale configs | ||
| self.write_channel(self.TELNET_RETURN + "clear" + self.TELNET_RETURN) | ||
| self.read_channel() | ||
| self.write_channel("end" + self.TELNET_RETURN) | ||
| output = self.find_prompt() | ||
| return_msg += output |
There was a problem hiding this comment.
I think it is gonna be dangerous as we will always have this prompt and try to clear it.
If we cant verify this is 1st time login , then we dont want to add this code..
I would rather focus on yes/no being passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.