Bump sha.js from 2.4.11 to 2.4.12 in /frontend#325
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
Bump sha.js from 2.4.11 to 2.4.12 in /frontend#325dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [sha.js](https://github.com/crypto-browserify/sha.js) from 2.4.11 to 2.4.12. - [Changelog](https://github.com/browserify/sha.js/blob/master/CHANGELOG.md) - [Commits](browserify/sha.js@v2.4.11...v2.4.12) --- updated-dependencies: - dependency-name: sha.js dependency-version: 2.4.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
51f0d05 to
a718864
Compare
Collaborator
|
Closing — lockfile-only transitive bump, covered by #418 (lockfile regeneration PR). |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
4 tasks
Kamirus
added a commit
that referenced
this pull request
Mar 23, 2026
## Summary - Bumped `tar` (7.5.9 → 7.5.11) and `minimatch` (10.0.1 → 10.2.4) in `cli/package.json` — security fixes for path traversal and ReDoS - Updated `cli/package-lock.json` and `docs/package-lock.json` transitive deps in-place to pick up security patches (lodash, js-yaml, node-forge, jws, undici, flatted, ajv, etc.) - `cli-releases/frontend` changes come from merged PR #340 (vite 5.2.6 → 5.4.21) - `frontend/package-lock.json` reverted to main — `npm update --legacy-peer-deps` introduced a `@dfinity/agent` ↔ `@dfinity/candid` peer dep conflict that broke CI - `blog/package-lock.json` was already up to date (no changes needed) ### What was NOT included and why - **`frontend/package-lock.json`** — peer dep conflict between `@dfinity/agent@1.0.1` and `@dfinity/candid@0.19.3` prevents a clean lockfile update. Needs a coordinated `@dfinity/*` dependency bump in a separate PR. - **Unfixable transitive vulns in CLI** — `axios` (via `wasm-pack` → `binary-install`) and `esbuild` (via `tsx`) can't be updated without breaking upstream. Pre-existing on main. ### Closed dependabot PRs (replaced by this PR) #368, #341, #344, #338, #345, #346, #349, #323, #328, #382, #353, #359, #357, #348, #325, #324, #421, #419, #379, #377 ## Test plan - [x] Benchmarks pass - [x] mops test passes (node 20 + node 24, all install methods) - [ ] CI workflow passes - [ ] Code quality (lint, format) passes ## Verification Ran findings-verifier on both direct dependency bumps: - **minimatch 10.0.1 → 10.2.4**: All changes are additive (new options, perf/security hardening). CLI uses a simple glob pattern unaffected by any changes. - **tar 7.5.9 → 7.5.11**: Pure security fixes in extraction path validation. No API surface changes. CLI's tar usage (create + extract) is standard and unaffected. - **No new peer deps**, no engine requirement changes, no breaking API changes. --- ## Remaining Open PRs — TODO ### Review & Merge (real package.json bumps, security fixes) | PR | What | Status | |---|---|---| | #336 | Vite 5.2.6 → 5.4.21 in `/frontend` | Multiple CVEs fixed | | #361 | Elliptic + ic-mops in `/frontend` | Critical crypto vulnerability | | #367 | Tar + ic-mops in `/frontend` | Tar path traversal fix | | #420 | Devalue + @sveltejs/kit in `/cli-releases/frontend` | Real package.json bump | ### Need @dependabot rebase (merge conflict with main) | PR | What | Status | |---|---|---| | #372 | Tar 7.5.6 → 7.5.7 in `/cli` | Now superseded — tar bumped to 7.5.11 in this PR | | #342 | Glob 11.0.1 → 11.1.0 in `/cli` | Security fix — GHSA-5j98-mcp5-4vw2 | ### Need Careful Review (major version bumps, risk of breakage) | PR | What | Status | |---|---|---| | #380 | Docusaurus 2.4.3 → 3.9.2 in `/docs` | Major v2 → v3. Test docs locally. | | #329 | vite-plugin-static-copy 1.0.2 → 2.3.2 in `/frontend` | Major v1 → v2. Has security fix but API may differ. | ### Non-Dependabot PRs | PR | Author | What | |---|---|---| | #411 | rvanasa | Test global Mops installation in CI | | #363 | codecustard | Fix code page scroll naturally like docs page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sha.js from 2.4.11 to 2.4.12.
Changelog
Sourced from sha.js's changelog.
Commits
eb4ea2fv2.4.12d8d77c0[meta] reorder package.jsondf9d521[eslint] fix package.json indentation35aec35[meta] addnpmignored528896[Dev Deps] add missing peer depb46e711[meta] addauto-changelog94ca724[Dev Deps] remove unusedbufferdep2dbe0aa[Dev Deps] update@ljharb/eslint-config73e33ae[Tests] avoid console logsf2a258e[Fix] support multi-byte wide typed arraysMaintainer changes
This version was pushed to npm by ljharb, a new releaser for sha.js since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.