Conversation
|
Are you planning to change the warning settings so that the unsigned/signed comparison warnings are no longer visible? |
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
5e90924 to
b467f86
Compare
|
Hi, please rebase onto master, i fixed some local variable shadowing issues. |
freeware-superman
force-pushed
the
fix/compile-warnings
branch
5 times, most recently
from
edb7cb4 to
51fdbb3
Compare
freeware-superman
force-pushed
the
fix/compile-warnings
branch
2 times, most recently
from
85b5fb1 to
d26e514
Compare
freeware-superman
force-pushed
the
fix/compile-warnings
branch
4 times, most recently
from
0befba3 to
76a12c4
Compare
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
e5affee to
848751a
Compare
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
67b34b4 to
090a681
Compare
jbreue16
left a comment
jbreue16
left a comment
There was a problem hiding this comment.
Hi there, thanks for working on this, seems like many warnings are fixed already !
What warnings are left? I think we should merge this and continue on another PR
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
ee4f332 to
085b50f
Compare
|
@freeware-superman What warnings are left? I think we should merge this and continue on another PR |
We plan to merge in the end of this week / beginning of next week. @freeware-superman wanted to have look on ubuntu specific warnings. |
Cool ! I think we should keep the commits separated and not squash. One small thing that I don't care too much about: Our standard commit message has a capital first letter |
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
085b50f to
c8c5617
Compare
Since C++23, empty spaces between quotation marks and suffixes are deprecated.
The lines changed were indented in a way that may lead to confusion when not reading extra carefully.
Since C++20 '[=]' is deprecated. For the original funtionality '[=, this]' should be used.
Using parentheses in complex statements leads to easier readability. This also prevents confusion with operator presedence.
The order of initialization matters. It should be the same as statet in the constructor. Not following that order can lead to members with unexpected values.
Functions returning only the value of a const variable may not be declared as const.
Running variables defined outside a loop don't need to be defined again.
Not including the header may lead to undefinded behaviour.
Non-void funtions should always return a value.
freeware-superman
force-pushed
the
fix/compile-warnings
branch
from
4c5b758 to
ae42d4e
Compare
AntoniaBerger
left a comment
AntoniaBerger
left a comment
There was a problem hiding this comment.
Great Work, thanks a lot! Looks super clean to me.
|
Ok Im having a couple of minutes while my CI runs so Ill add the two changes, force-push and merge |
If a body is intenionally empty it should be clearly marked. If-statement was removed since not required. Co-authored-by: Jan Breuer <74359367+jbreue16@users.noreply.github.com>
A function labeld as having no exceptions should not have exceptions.
A comparison that can never be true (e.g. if(positive_number < 0) ) a warning is raised. Co-authored-by: Jan Breuer <74359367+jbreue16@users.noreply.github.com>
If a return value is intentionally ignored, it should be explicitly marked in code by casting to void.
A struct with unitialized members may lead to uninteded behaviour.
jbreue16
force-pushed
the
fix/compile-warnings
branch
from
ae42d4e to
8b95837
Compare
3 participants
This PR resolves all issues leading to compile warnings. Already excluded warnings do not get resolved. -Wsign-compare will be handled in a seperate PR as it needs a lot more changes.
Some smaller issues that are found along the way get resolved as well.