Skip to content

Feature/update sundials 7.1.1#467

Draft
daklauss wants to merge 13 commits intomasterfrom
feature/update-sundials-7.1.1
Draft

Feature/update sundials 7.1.1#467
daklauss wants to merge 13 commits intomasterfrom
feature/update-sundials-7.1.1

Conversation

@daklauss
Copy link
Copy Markdown
Member

@daklauss daklauss commented Aug 11, 2025

This Draft updates to sundials 7.1.1 with vcpkg
Fixes #154

TODOS/Problems to solve:

  • CMAKE/include/CICD files, sundials>=7 uses a generic sundials_core, that needs to be included for compilation
    • updatet cmake files necessary as well as different headers in code
    • ubuntu-latest only has sundials<=6.4.1 => own build within ci/cd pipeline necessary or using sundials<7
    • Update SimulatorImpl and gmres
  • ida_impl.h got removed with sundials>=4.1 => IDAMem not accessible anymore
    • IDA_mem->ida_lsolve = &linearSolveWrapper; not possible anymore, need sunlinearsolver "object" with own linear solver
    • IDASetMaxNonlinIters(_idaMemBlock, _maxNewtonIter); led to a crash
    • weights got removed from solve call of idas linsolver? setscalingvectors? couldnt find change history
  • suncontext "object" is needed to be created, handles sundials own error logs with sundials 6
  • Set sensmaxnonliniters after idasensinit point 20
  • conduct performance benchmark
  • Create follow-ups

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 11, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@daklauss
Copy link
Copy Markdown
Member Author

  • The CADET maintainers know my real name.

At least one of the following two applies:

  • The CADET maintainers know my current employer.

  • I am not making this contribution on behalf of my current employer.

@daklauss
Copy link
Copy Markdown
Member Author

I have read the CLA Document and I hereby sign the CLA.

@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 4 times, most recently from ead18d0 to 953dbfc Compare August 19, 2025 11:10
@cadet cadet deleted a comment from daklauss Aug 19, 2025
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 3 times, most recently from 3f973d5 to bccc591 Compare August 26, 2025 09:12
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from bccc591 to 980ef48 Compare October 7, 2025 09:23
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 6 times, most recently from 843f734 to bd9c003 Compare October 22, 2025 12:55
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 2 times, most recently from 8586a25 to 95f8267 Compare November 4, 2025 10:28
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 2 times, most recently from 6920cf0 to 57f2333 Compare November 18, 2025 12:05
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 5 times, most recently from 3282f96 to 867cf4d Compare February 13, 2026 12:24
@daklauss daklauss requested a review from jbreue16 February 13, 2026 12:29
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 2 times, most recently from ba7d334 to 6c88888 Compare February 20, 2026 09:32
Comment thread src/libcadet/SimulatorImpl.cpp
Comment thread src/libcadet/SimulatorImpl.cpp
Comment thread src/libcadet/SimulatorImpl.cpp Outdated
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from cbe1d52 to 9a5ffe0 Compare March 17, 2026 19:20
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from bd49341 to 4827c42 Compare April 8, 2026 11:20
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 2 times, most recently from 8c308fb to 65c3fd7 Compare April 16, 2026 08:17
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from 65c3fd7 to 843abd3 Compare April 21, 2026 08:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/libcadet/SimulatorImpl.cpp 42.38% <ø> (+0.27%) ⬆️
src/libcadet/SimulatorImpl.hpp 25.00% <ø> (ø)
src/libcadet/linalg/Gmres.cpp 63.08% <ø> (+0.78%) ⬆️
src/libcadet/linalg/Gmres.hpp 85.71% <ø> (ø)

... and 3 files with indirect coverage changes

@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from 3b8d3ec to 78521ce Compare April 21, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Update to latest SUNDIALS version

2 participants