Draft
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
9c0bb18 to
2cf9307
Compare
Member
Author
At least one of the following two applies:
|
Member
Author
|
I have read the CLA Document and I hereby sign the CLA. |
ead18d0 to
953dbfc
Compare
3f973d5 to
bccc591
Compare
bccc591 to
980ef48
Compare
843f734 to
bd9c003
Compare
8586a25 to
95f8267
Compare
6920cf0 to
57f2333
Compare
3282f96 to
867cf4d
Compare
ba7d334 to
6c88888
Compare
jbreue16
reviewed
Feb 20, 2026
cbe1d52 to
9a5ffe0
Compare
bd49341 to
4827c42
Compare
8c308fb to
65c3fd7
Compare
65c3fd7 to
843abd3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
|
3b8d3ec to
78521ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Draft updates to sundials 7.1.1 with vcpkg
Fixes #154
TODOS/Problems to solve:
sundials_core, that needs to be included for compilationubuntu-latestonly has sundials<=6.4.1 => own build within ci/cd pipeline necessary or using sundials<7SimulatorImplandgmresida_impl.hgot removed with sundials>=4.1 =>IDAMemnot accessible anymoreIDA_mem->ida_lsolve = &linearSolveWrapper;not possible anymore, need sunlinearsolver "object" with own linear solverIDASetMaxNonlinIters(_idaMemBlock, _maxNewtonIter);led to a crashN_VectorinstancesSUNContext_PushErrHandlerinstead ofIDASetErrHandlerFnsundials 7 (Error Handling Changes)TimeIntegratorfor sundials v7 #584