Skip to content

Add FV particle diffusion operator#465

Open
jbreue16 wants to merge 7 commits intomasterfrom
feature/dg2d
Open

Add FV particle diffusion operator#465
jbreue16 wants to merge 7 commits intomasterfrom
feature/dg2d

Conversation

@jbreue16
Copy link
Copy Markdown
Contributor

@jbreue16 jbreue16 commented Aug 7, 2025

todo

  • copy FV particle discretization from GRM_FV to new ParticleDiffusionOperatorFV and adapt to ParticleDiffusionOperatorBase interface
  • enable ParticleDiffusionOperatorFV in GeneralRateParticle
  • flip particle state
  • move out jacobian from residual, similar to DG operator
  • tests
    • add a generalized discretization setter to allow mixed discretizations in tests
    • reference tests
      • num.ref: LRMP DG == GRM bulk DG par FV with nparcell = 1 and sensitivities
      • linear binding analytical reference
      • GRM SMA LWE numref comparison with pure DG solution
      • another sensitivity test?
    • Jacobian
      • single component no bnd
      • 1 comp linear: with surfDiff, req binding
      • 2 comp linear: with surfDiff, kin binding
  • Warning for nParCell = 1, wrong use of model
  • documentation
  • Add mixed bulk DG particle FV benchmark CADET-Verification#120

@jbreue16 jbreue16 force-pushed the feature/dg2d branch 2 times, most recently from 2a5a005 to 762bc3a Compare August 8, 2025 12:40
jbreue16 added a commit that referenced this pull request Aug 8, 2025
jbreue16 added a commit that referenced this pull request Aug 8, 2025
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 14 times, most recently from c34f907 to 5899a91 Compare August 14, 2025 14:59
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 3 times, most recently from 4917d31 to 8b068a4 Compare August 18, 2025 20:18
jbreue16 added a commit that referenced this pull request Aug 19, 2025
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 force-pushed the jb/dev branch 4 times, most recently from 143ff67 to 6191c90 Compare August 25, 2025 16:34
jbreue16 added a commit that referenced this pull request Aug 26, 2025
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 force-pushed the jb/dev branch 3 times, most recently from 31930b9 to da9a50c Compare August 26, 2025 16:22
jbreue16 added a commit that referenced this pull request Aug 29, 2025
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 self-assigned this Aug 29, 2025
@jbreue16 jbreue16 changed the base branch from jb/dev to master August 29, 2025 09:08
jbreue16 added a commit that referenced this pull request Aug 29, 2025
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
jbreue16 added a commit that referenced this pull request Aug 29, 2025
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 2 times, most recently from 57809e4 to 639b47c Compare August 29, 2025 14:02
jbreue16 added a commit that referenced this pull request Aug 29, 2025
Also makes field `SPATIAL_METHOD` in particle discretization mandatory
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant