Draft
Conversation
Following the tutorial for custom binding model and trying to add the custom binding model Test.
schmoelder
requested changes
Apr 26, 2024
Contributor
schmoelder
left a comment
schmoelder
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Without having tested your code (or checked the math), I added some comments that I would ask you to address before we can accept any PR.
Let us know if you have any questions.
Contributor
There was a problem hiding this comment.
please do not remove the CI files
Contributor
There was a problem hiding this comment.
please do not remove the CI files
| @@ -1,4 +1,4 @@ | |||
| CADET | |||
| CADET (my version) | |||
Contributor
There was a problem hiding this comment.
Please rename your model and give it a more descriptive name. Note, this also involves changing the file names in other places, e.g. CMake files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test binding model trying to be implamented is the same as the one here, but with Langmuir replaced with Test.