Automatic code formatting using pre-commit and clang-format#148
Open
Automatic code formatting using pre-commit and clang-format#148
Conversation
Contributor
|
This would fix #99. |
Contributor
|
I like this! :) |
Uses pre-commit and clang-format to automatically format code before it is committed.
Ignores VS Code and clangd LSP directories.
ad8f5c6 to
388ba80
Compare
|
Thank you for your submission, we really appreciate it! Like many open-source projects we ask that you sign our Contributor License Agreement before we can accept your contribution.
- [ ] The CADET maintainers know my real name.
At least one of the following two applies:
- [ ] The CADET maintainers know my current employer.
- [ ] I am *not* making this contribution on behalf of my current employer.
|
Contributor
|
I've updated the PR to the current master, updated clang and re-formatted everything to confirm nothing breaks. The |
Contributor
To set up on windows:
To process all files with the new pre-committ workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables support for pre-commit and clang-format. Code is automatically formatted before committing.
Options for clang-format are documented here. I used this online preview for various clang-format settings. I'm still not fully satisfied, but it's a start.
I'm not sure how this PR will impact other PRs and their "mergeability".