Improve parameter checks for flowrate_filter#109
Draft
schmoelder wants to merge 3 commits intomasterfrom
Draft
Conversation
3cb1519 to
11ac434
Compare
Contributor
|
You propose to change void CSTRModel::notifyDiscontinuousSectionTransition(double t, unsigned int secIdx, const ConstSimulationState& simState, const AdJacobianParams& adJac)
{
if (_flowRateFilter.size() > 1)
{
_curFlowRateFilter = getSectionDependentScalar(_flowRateFilter, secIdx);
}
else if (_flowRateFilter.size() == 1)
{
_curFlowRateFilter = _flowRateFilter[0];
}
}You can further simplify, because this is equivalent: void CSTRModel::notifyDiscontinuousSectionTransition(double t, unsigned int secIdx, const ConstSimulationState& simState, const AdJacobianParams& adJac)
{
_curFlowRateFilter = getSectionDependentScalar(_flowRateFilter, secIdx);
} |
Contributor
I don't know either. Would need to scan through the code as well. |
cbe8b6e to
895538d
Compare
895538d to
0f7defb
Compare
|
|
||
| // Hand model over to simulator | ||
| _sim->initializeModel(*model); | ||
| _sim->setSectionTimes(secTimes, secCont); |
Contributor
There was a problem hiding this comment.
If this is deleted, section times will not be propagated into the models. But, this is required for the inlet profiles to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial draft to improve parameter checks.
In the given example, the
FLOWRATE_FILTERaccidentally did not have enough entries. Because its length was still > 0, CADET assumed it was a section depenent parameter. However, when compiled with g++, the CADET would exceed the bounds of the array and only (sometimes) crash much later. On Windows, it crashes immediately when exceeding the bounds of the array.By calling
getSectionDependentScalar(_flowRateFilter, secIdx)instead of indexing directly, it also crashes on Linux.A more elegant approach would be to check the length of section dependent parameters before even starting the simulation. This way, the user knows directly that the configuration is invalid. @sleweke is this done somewhere in CADET for other section dependent parameters? I couldn't find anything.
Example
Partially fixes #28