fix(file_server): persist browse layout setting using localStorage#7604
Open
xingzihai wants to merge 1 commit intocaddyserver:masterfrom
Open
fix(file_server): persist browse layout setting using localStorage#7604xingzihai wants to merge 1 commit intocaddyserver:masterfrom
xingzihai wants to merge 1 commit intocaddyserver:masterfrom
Conversation
Issue caddyserver#6386: Layout setting (list/grid) was not saved and reset on page refresh. Root cause: Layout preference was only stored in URL query parameter. When navigating to a new path or refreshing without the parameter, layout would reset to default (list). Solution: Persist layout choice using localStorage: - Save layout to localStorage when user clicks layout buttons - On page load, check localStorage and update URL if needed This ensures layout preference persists across: - Page refreshes - Navigation to different directories - New browser sessions
|
|
Member
|
Missing the AI disclosure section (part of the PR template), and CLA needs to be signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the file_server browse layout setting was not persisted.
Fixes #6386
Changes:
Testing:
Test by changing the layout in file_server browse, then navigating to a different directory and back. The layout setting should persist.