fix(auth): preserve WWW-Authenticate header with multiple providers#7602
Open
xingzihai wants to merge 1 commit intocaddyserver:masterfrom
Open
fix(auth): preserve WWW-Authenticate header with multiple providers#7602xingzihai wants to merge 1 commit intocaddyserver:masterfrom
xingzihai wants to merge 1 commit intocaddyserver:masterfrom
Conversation
When multiple authentication providers are configured and the first provider fails (returning 401 with WWW-Authenticate header), subsequent providers are tried. If all providers fail, the response should include the WWW-Authenticate header from the first failed provider. This fix uses a response recorder to isolate each provider's side effects and applies the first failed provider's headers to the final response. Issue: caddyserver#5190
|
|
Member
|
Missing the AI disclosure section (part of the PR template), and CLA needs to be signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5190
Summary
This PR preserves the WWW-Authenticate header when multiple authentication providers are configured.
Changes
Testing