Add sharing_id Caddyfile directive#14
Open
bjorn wants to merge 1 commit into
Open
Conversation
Sets Provider.SharingId on the underlying libdns/gandi provider, which sends X-Gandi-Sharing-Id on every API call. Required when the PAT user's default organization isn't the one that owns the domain; without it Gandi 404s on per-record-set endpoints. Drive-by while in the same parser: the existing block-form `bearer_token <value>` branch read d.Val() before advancing past the directive name, so it stored the literal string "bearer_token" in BearerToken and then tripped d.NextArg() on the actual value, returning a "wrong argument count" error. Same fix applied here for sharing_id. Depends on libdns/gandi#15 (which adds the SharingId field). Once that lands, bump the libdns/gandi require accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
Provider.SharingIdon the underlyinglibdns/gandiprovider, which sendsX-Gandi-Sharing-Idon every API call. Required when the PAT user's default organization isn't the one that owns the domain; without it Gandi 404s on per-record-set endpoints.Drive-by while in the same parser: the existing block-form
bearer_token <value>branch readd.Val()before advancing past the directive name, so it stored the literal string "bearer_token" in BearerToken and then trippedd.NextArg()on the actual value, returning a "wrong argument count" error.Depends on libdns/gandi#15 (which adds the
SharingIdfield). Once that lands, bump thelibdns/gandirequire accordingly.