fix(react-router): use queueMicrotask for fireViewReady deferral (setTimeout fallback)#17
Open
olehmisar wants to merge 1 commit intocactuslab:developfrom
Open
Conversation
…lback setTimeout(..., 1) deferred viewReady enough to cause a visible flash after native tab work. Prefer queueMicrotask when available; fall back to setTimeout for older runtimes without queueMicrotask. Made-with: Cursor
Author
|
the PR is generated by AI but the fix is legit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calling
fireViewReadyaftersetTimeout(..., 1)deferred the nativeviewReadysignal enough to produce a visible flash when switching native tabs (reported in production FamilyTable builds).Change
scheduleViewReadyCallbackthat prefersqueueMicrotaskso the deferral stays within the same macrotask ordering expectations without the extra timer delay.setTimeout(callback, 1)whenqueueMicrotaskis not a function (older runtimes).Testing
pnpm buildat repo root (all packages) succeeds.Made with Cursor