fix: use dynamic ndkVersion in android/build.gradle#13
Open
aryaminus wants to merge 1 commit intocactus-compute:mainfrom
Open
fix: use dynamic ndkVersion in android/build.gradle#13aryaminus wants to merge 1 commit intocactus-compute:mainfrom
aryaminus wants to merge 1 commit intocactus-compute:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the NDK version configurable by using the getExtOrDefault() helper function, allowing it to be defined dynamically through rootProject.ext.ndkVersion or via gradle.properties (Cactus_ndkVersion). This aligns with the existing pattern used for other configuration values like kotlinVersion, and ensures the NDK version can be consistently managed across the workspace rather than being hardcoded or left to Android's defaults.
Key Changes:
- Adds dynamic
ndkVersionconfiguration using the existinggetExtOrDefault()helper, following the established pattern for string-based version properties
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
android/build.gradleto setndkVersiondynamically usinggetExtOrDefault("ndkVersion").Motivation
Instead of hardcoding the NDK version or relying on defaults, this change allows the
ndkVersionto be defined in the root project orgradle.properties, ensuring consistency across the workspace and matching the environment configuration (e.g.,27.1.12297006). This aligns with how other versions likeminSdkVersionare handled.