Skip to content

fix: use dynamic ndkVersion in android/build.gradle#13

Open
aryaminus wants to merge 1 commit intocactus-compute:mainfrom
aryaminus:fix/dynamic-ndk-version
Open

fix: use dynamic ndkVersion in android/build.gradle#13
aryaminus wants to merge 1 commit intocactus-compute:mainfrom
aryaminus:fix/dynamic-ndk-version

Conversation

@aryaminus
Copy link

Summary

  • Update android/build.gradle to set ndkVersion dynamically using getExtOrDefault("ndkVersion").

Motivation

Instead of hardcoding the NDK version or relying on defaults, this change allows the ndkVersion to be defined in the root project or gradle.properties, ensuring consistency across the workspace and matching the environment configuration (e.g., 27.1.12297006). This aligns with how other versions like minSdkVersion are handled.

Copilot AI review requested due to automatic review settings November 27, 2025 21:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the NDK version configurable by using the getExtOrDefault() helper function, allowing it to be defined dynamically through rootProject.ext.ndkVersion or via gradle.properties (Cactus_ndkVersion). This aligns with the existing pattern used for other configuration values like kotlinVersion, and ensures the NDK version can be consistently managed across the workspace rather than being hardcoded or left to Android's defaults.

Key Changes:

  • Adds dynamic ndkVersion configuration using the existing getExtOrDefault() helper, following the established pattern for string-based version properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant