fix: remove unnecessary react plugin to avoid duplicate class generation#11
Open
aryaminus wants to merge 2 commits intocactus-compute:mainfrom
Open
fix: remove unnecessary react plugin to avoid duplicate class generation#11aryaminus wants to merge 2 commits intocactus-compute:mainfrom
aryaminus wants to merge 2 commits intocactus-compute:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the com.facebook.react plugin from the library's Android build configuration to prevent duplicate class generation in a monorepo setup. The library uses Nitrogen/Nitro for code generation instead of React Native's standard Codegen, making the React plugin unnecessary and conflicting when both the library and example app apply it.
Key Changes
- Removed
apply plugin: "com.facebook.react"from the library'sandroid/build.gradle - This prevents duplicate TurboModule class generation (e.g.,
RNCSafeAreaProviderManagerDelegate) when the example app also scans dependencies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.facebook.reactplugin to prevent duplicate class generation for TurboModules in the monorepo.Motivation
The
com.facebook.reactplugin is primarily for apps. When applied to a library in a workspace, it scans dependencies and generates code for TurboModules (likereact-native-safe-area-context). Since the example app also applies this plugin, it causes duplicate class errors (e.g.,RNCSafeAreaProviderManagerDelegate). This library uses Nitrogen, so the standard plugin is not required.