Skip to content

feat(nil) Add option to treat warnings as errors #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjamb wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

feat(nil) Add option to treat warnings as errors #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion modules/hooks.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,19 @@ in
imports = [ hookModule ];
};
};
nil = mkOption {
description = "nil hook";
type = types.submodule {
imports = [ hookModule ];
options.settings = {
denyWarnings = mkOption {
type = types.bool;
description = "Treat warnings like errors and exit with non-zero code";
default = false;
};
};
};
};
nixfmt = mkOption {
description = "nixfmt hook";
type = types.submodule {
Expand Down Expand Up @@ -3439,11 +3452,14 @@ lib.escapeShellArgs (lib.concatMap (ext: [ "--ghc-opt" "-X${ext}" ]) hooks.fourm
package = tools.nil;
entry =
let
cmdArgs = mkCmdArgs (with hooks.nil.settings; [
[ denyWarnings "--deny-warnings" ]
]);
script = pkgs.writeShellScript "precommit-nil" ''
errors=false
echo Checking: $@
for file in $(echo "$@"); do
${hooks.nil.package}/bin/nil diagnostics "$file"
${hooks.nil.package}/bin/nil diagnostics ${cmdArgs} "$file"
exit_code=$?

if [[ $exit_code -ne 0 ]]; then
Expand Down