Fix unsubscribe command argument mismatch#4608
Open
Misrilal-Sah wants to merge 1 commit intocachethq:developfrom
Open
Fix unsubscribe command argument mismatch#4608Misrilal-Sah wants to merge 1 commit intocachethq:developfrom
Misrilal-Sah wants to merge 1 commit intocachethq:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect command dispatch in the unsubscribe flow by aligning the UnsubscribeSubscriberCommand instantiation with its constructor signature (subscriber-only), preventing runtime ArgumentCountError issues on stricter PHP versions.
Changes:
- Update
SubscribeController@getUnsubscribeto dispatchUnsubscribeSubscriberCommandwith only theSubscriberargument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link id: N/A (proactive bugfix found during unsubscribe-path audit)
Description:
Fixes incorrect command dispatch that passed extra arguments to UnsubscribeSubscriberCommand.
The command constructor accepts only the subscriber, so this mismatch can cause runtime issues on stricter PHP versions.
Updated dispatch call to match command signature exactly.