Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dev-ready-timeout.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@dawn-ai/cli": patch
---

`dawn dev` startup readiness timeout is now configurable via `DAWN_DEV_READY_TIMEOUT_MS` (default unchanged at 5s). Also de-flakes the dev-command disposal test that raced child startup against the readiness window in CI.
13 changes: 12 additions & 1 deletion packages/cli/src/lib/dev/dev-session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ class InternalDevSession {

try {
await child.waitForReady()
await waitForDevServerReady(this.url)
await waitForDevServerReady(this.url, { timeoutMs: readReadyTimeoutMs() })
} catch (error) {
await child.stop(readShutdownTimeoutMs())

Expand Down Expand Up @@ -399,3 +399,14 @@ function readShutdownTimeoutMs(): number {
const parsedValue = Number(rawValue)
return Number.isFinite(parsedValue) ? parsedValue : 1_000
}

function readReadyTimeoutMs(): number {
const rawValue = process.env.DAWN_DEV_READY_TIMEOUT_MS

if (!rawValue) {
return 5_000
}

const parsedValue = Number(rawValue)
return Number.isFinite(parsedValue) ? parsedValue : 5_000
}
3 changes: 2 additions & 1 deletion packages/cli/test/dev-command.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ describe("dawn dev lifecycle", () => {
env: {
DAWN_DEV_CHILD_PID_PATH: pidPath,
DAWN_DEV_CHILD_TEST_MODE: "report-ready-without-server",
DAWN_DEV_READY_TIMEOUT_MS: "15000",
},
})
devProcesses.push(dev)
Expand Down Expand Up @@ -739,7 +740,7 @@ async function delay(ms: number): Promise<void> {
await new Promise((resolve) => setTimeout(resolve, ms))
}

async function waitForPath(path: string, timeoutMs = 2_000): Promise<void> {
async function waitForPath(path: string, timeoutMs = 10_000): Promise<void> {
const startedAt = Date.now()

while (Date.now() - startedAt < timeoutMs) {
Expand Down