fix(ag-ui): advanced markers ignore clicks — set gmpClickable#749
Conversation
Regression from the AdvancedMarkerElement migration: the legacy
google.maps.Marker was clickable by default, but AdvancedMarkerElement is
NOT — without gmpClickable it never fires click/gmp-click, so the wrapper's
(mapClick) output stays silent and the marker info window (focus + Remove)
never opens. Pass { gmpClickable: true } via the marker [options].
Found by Brian during live review; verified live in Chrome — markers report
gmpClickable=true and clicking opens the info window. (The "use gmp-click"
console hint was this bug's symptom, not noise.)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @blove's task in 37s —— View job Code Review
Verdict: LGTM The fix is correct and minimal. A few quick observations: Correctness — The root cause diagnosis is accurate. Without No binding conflicts — Shared object is safe — All markers sharing the same options reference is correct here since Comment quality — The explanatory comment at the property declaration is worth keeping; this is a non-obvious platform behaviour that would trip up anyone unfamiliar with the No issues found. |
Marker clicks on the App-mode map did nothing (no info window / focus / Remove). Regression from the AdvancedMarkerElement migration: legacy
Markeris clickable by default,AdvancedMarkerElementis not — withoutgmpClickable: trueit never firesclick/gmp-click, so(mapClick)stays silent. The "use gmp-click" console hint was the symptom.Fix: pass
{ gmpClickable: true }via the marker[options](+7 lines).Verified: live in Chrome (markers report
gmpClickable=true, click opens the info window with Remove), lint 0 errors, unit ✓, build ✓ against post-#747 main.🤖 Generated with Claude Code