Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ag-ui): AdvancedMarkerElement + Map ID for the App-mode map #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(ag-ui): AdvancedMarkerElement + Map ID for the App-mode map #745
Changes from all commits
07ce17f8e52299508b037d0f7068File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makePinallocates a newHTMLElementfor every stop on every execution of this computed.stopsWithCoords()recomputes whenever any stop mutates — including text-only changes (agent renames a place, adds a note) — so all pin nodes are silently replaced even when no day or position changed. The old elements handed to the Maps API are detached and GC'd, so it's not a correctness bug, but it's more aggressive DOM churn than the@for track m.idrhythm implies.An easy guard: key the element by
(s.id, s.day)with aMapcache so pins are only rebuilt when the day (i.e., colour) actually changes:Or, if you prefer a lighter touch, just leave a comment clarifying that "stops change" includes text edits, so readers aren't surprised.
Uh oh!
There was an error while loading. Please reload this page.