Open
Conversation
evrardjp-cagip
approved these changes
Dec 19, 2024
evrardjp-cagip
requested changes
Dec 19, 2024
Contributor
evrardjp-cagip
left a comment
evrardjp-cagip
left a comment
There was a problem hiding this comment.
go releaser install script is fetched from upstream. Can you do this in the Makefile OR propose a fix upstream instead?
Without this, there is an incomprehensible error if sha256sum does not present. This fixes by determining the reason for error sha256sum not present
zkonak
force-pushed
the
feat/sha256sum_fail
branch
from
565b084 to
fa07618
Compare
| mkdir -p $(HACKDIR) | ||
|
|
||
| bootstrap-tools: $(HACKDIR) | ||
| if ! command -v sha256sum &> /dev/null; then echo "sha256sum could not be found"; exit 1; fi |
Contributor
There was a problem hiding this comment.
This is not valid in terms of Makefile. maybe check for @ or shell ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, there is an incomprehensible error if sha256sum does not present.
This fixes by determining the reason for error sha256sum not present