FIX: [xalign] include created order id in thread reply

[dboyliao]

No description provided.

[Copilot]

Pull request overview

This PR enhances the xalign strategy's Slack integration by including created order IDs in thread replies when users interact with already-processed orders. This provides better visibility into the order submission results after the interactive buttons have been processed.

Key Changes:

• Added submittedOrderRegistry sync.Map to persist submitted order information
• Implemented automatic cleanup of orders older than 2 hours from the registry
• Enhanced Slack interaction callback to display created order details when users click buttons on already-processed orders

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[c9s]

can use time.Since to replace now.

[dboyliao]

I refactor it and pass now as a parameter.
The reason for that is to make mocking now possible so I can write test on the case where ttl is due.

[c9s]

maybe we can call createdOrder.SlackBlocks()?

we need to implement order.SlackBlocks()

[dboyliao]

done.

[dboyliao]

I use .SlackAttachment() instead.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

pkg/strategy/xalign/slack.go:294

• The variable 'io' is assigned from 'value' but this is redundant since 'itOrder' was already type-asserted from 'value' at line 251. The check at line 252 already ensures that 'value' is of type '*InteractiveSubmitOrder' and assigns it to 'itOrder', so this second type assertion and assignment is unnecessary. You can directly use 'itOrder' instead of 'io' in the rest of the function.

			return []interact.InteractionMessageUpdate{
				{
					Blocks:       nil,
					Attachments:  nil,
					PostInThread: false,
				},
			}, fmt.Errorf("invalid type detected for interactive order (%s): %+v", actionValue, value)
		}

		blocks := removeBlockByID(oriMessage.Blocks.BlockSet, interactiveButtonsBlockID)
		switch actionID {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gx578007]

Is it possible that order is nil here?

[dboyliao]

Yes.
It should be handled by the callback.

[gx578007]

Okay. Just want to make sure the type assertion at line 274 won't panic.