FIX: [xalign] interactive order enable flag#2367
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a feature flag for interactive orders in the xalign strategy with automatic disabling when Slack interaction is not configured. The change introduces a getter method SlackInteractionEnabled() on the bbgo.Environment to check if Slack interaction is enabled, and adds the InteractiveOrderEnabled flag to the xalign strategy configuration to control whether orders require interactive Slack confirmation.
Key Changes
- New
SlackInteractionEnabled()getter method inbbgo.Environmentto expose the interactive Slack state - Added
InteractiveOrderEnabledconfiguration flag to the xalign strategy - Modified order placement logic to bypass interactive confirmation when the feature is disabled
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/bbgo/environment.go | Adds interactiveSlackEnabled field and SlackInteractionEnabled() getter to expose Slack interaction state |
| pkg/strategy/xalign/strategy.go | Adds InteractiveOrderEnabled configuration field and updates order placement logic to check if interactive orders are enabled |
| pkg/strategy/xalign/slack.go | Adds isInteractiveOrderEnabled() helper method and updates setupSlackInteractionCallback() to accept an enabled flag |
| pkg/strategy/xalign/slack_test.go | Updates test call to setupSlackInteractionCallback() with new signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7397cc1 to
8433119
Compare
8433119 to
4dcbe67
Compare
c9s
approved these changes
Jan 2, 2026
gx578007
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InteractiveOrderEnabled