Open
Conversation
c910335
reviewed
Oct 13, 2017
main.kt
Outdated
| repeat(n - 1) { i -> | ||
| print(" ${ranks[i + 1]}") | ||
| } | ||
| println("") |
Owner
There was a problem hiding this comment.
How about println(ranks.joinToString(" "))?
davy-tw
force-pushed
the
kotlin
branch
2 times, most recently
from
a663121 to
56e32ca
Compare
Author
|
Updated with insertion sort mentioned in #7 |
c910335
requested changes
Oct 17, 2017
| } | ||
|
|
||
| fun findRank(ranks: IntArray, points: MutableList<Point>) : List<Point> { | ||
| if (points.size <= 1) return points |
Author
There was a problem hiding this comment.
No, this is necessary for avoiding re-layout a ArrayList below (Line 55), this can be more efficiently in Kotlin.
Owner
There was a problem hiding this comment.
But it never get into this since points.size <= THRESHOLD cover this condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.