complex: Fix expm1 formula computing exp(z-1) instead of exp(z)-1 #1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
expm1functionexpm1to prevent regressionProblem
The complex implementation of
expm1(z)incorrectly computede^(z-1)instead ofe^z - 1.For example:
expm1(0)returnede^(-1) ≈ 0.3679instead of0expm1(1)returnede^0 = 1instead ofe - 1 ≈ 1.7183Fix
Changed
src/complex.ccline 1275 fromexp(z - one)toexp(z) - one.Known Limitations
This fix corrects the formula but is still a temporary solution. For small values of
z, computingexp(z) - 1directly suffers from catastrophic cancellation. A proper implementation should use a numerically stable algorithm (e.g., Taylor series for small|z|).Testing
complex_functions()-Tflag - no regressions