Skip to content

fix(cli): reject profile command session filters#309

Merged
upsetbit merged 1 commit into
masterfrom
codex/reject-profiles-session-globals
Jun 27, 2026
Merged

fix(cli): reject profile command session filters#309
upsetbit merged 1 commit into
masterfrom
codex/reject-profiles-session-globals

Conversation

@upsetbit

Copy link
Copy Markdown
Contributor

Summary

Fixes #297.

Profiles commands now reject inherited session-query globals that do not apply to local profile configuration.

What changed

  • Added validation for --last, --since, --between, --project, --device, --agent, --profile, --all, and --remote on profiles commands.
  • Kept --json and --no-color usable for profiles output/mutations.
  • Added command tests for the issue's no-op cases.

Validation

  • go test ./internal/cli -run 'TestProfiles' -count=1
  • go test ./internal/cli/... -race
  • go build -o ./bin/prosa ./cmd/prosa
  • Manual checks for profiles list --json --last notaduration, --last 1d --since 2026-01-01, --profile work, and --remote

@upsetbit upsetbit added bug Something isn't working area:cli prosa CLI scope:cli prosa CLI commands, flags, rendering, setup, and scheduled sync severity:medium Latent bug, inconsistent contract, brittle pattern priority:P2 Lower-priority cleanup, coverage, polish, or follow-up source:audit Created from an audit report or validation pass labels Jun 27, 2026
@upsetbit upsetbit merged commit ae68b70 into master Jun 27, 2026
4 checks passed
@upsetbit upsetbit deleted the codex/reject-profiles-session-globals branch June 27, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:cli prosa CLI bug Something isn't working priority:P2 Lower-priority cleanup, coverage, polish, or follow-up scope:cli prosa CLI commands, flags, rendering, setup, and scheduled sync severity:medium Latent bug, inconsistent contract, brittle pattern source:audit Created from an audit report or validation pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

profiles list silently ignores session-query globals

1 participant