ci(node): use --no-gh-release for napi pre-publish#12
Merged
Conversation
`napi pre-publish` has no `--skip-gh-release` flag; the option is the boolean `--gh-release` (default true), so skipping the GitHub release is `--no-gh-release`. The wrong flag aborted the publish at argument parsing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm publish aborted at argument parsing:
napi pre-publishhas no--skip-gh-releaseoption (that string was from the original placeholder).The flag is the boolean
--gh-release(default true); skipping the GitHubrelease is
--no-gh-release. Verified against the installed@napi-rs/cli.No packages were published (the error is pre-action), so npm 0.1.0 is still
clean. This unblocks the publish.
🤖 Generated with Claude Code