ci(node): pin release rust toolchain so cross targets build#10
Merged
Conversation
The build matrix installed each target's rust-std on `stable`, but `napi build` honors rust-toolchain.toml (1.90.0), which then lacked `core` for the cross targets (aarch64-gnu, both musl, x86_64-darwin). Pin the toolchain to 1.90.0 so the target std lands where the build uses it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
node-v0.1.0release build failed on all four cross-compiled targets(
aarch64-unknown-linux-gnu, both musl,x86_64-apple-darwin) witherror[E0463]: can't find crate for core.Cause:
Setup Rustuseddtolnay/rust-toolchain@stable, installing eachtarget's
rust-stdon thestabletoolchain. Butnapi buildruns cargo inthe repo where
rust-toolchain.tomlpins1.90.0, so the build used 1.90.0 —which had no
rust-stdfor the cross targets. Native-arch builds passed becauserustup auto-fetches the host std for the pinned toolchain.
Fix: pin the release toolchain to
1.90.0(matchingrust-toolchain.toml)so the per-target
rust-stdlands on the toolchain the build actually uses.Pre-existing bug — the release workflows never ran before (publish steps were
placeholders and Actions billing blocked earlier runs). crates.io and PyPI
0.1.0 already published successfully; this unblocks the npm 0.1.0 re-run.
🤖 Generated with Claude Code