add k-256 support#81
Conversation
|
@iameli Thanks for reaching out with this proposal. I will bring it to the team for discussion and report back! |
| <ul> | ||
| <li> | ||
| <p>ECDSA requires elliptic curve keys on the P-256, P-384, or P-521 elliptic curves.</p> | ||
| <p>ECDSA requires elliptic curve keys on the P-256, K-256, P-384, or P-521 elliptic curves.</p> |
There was a problem hiding this comment.
I need to do a bit of research to refresh my memory, but the typical concern with K-256 is that there are a few scenarios where timing attacks could leak information. As used in crypto-currency implementations, the timing attacks are impractical. Generalized use in C2PA might??? be problematic in some scenarios. Leonard, let me know if you want me to dig up the details or run this by cryptographers I work with.
There was a problem hiding this comment.
My understanding is that certain properties of K-256 can make it more challenging to write constant-time implementations. But people did it anyway - all of the recommended implementations are constant-time, including the Rust k256 crate used in my c2pa-rs fork.
My PR for this on c2pa-rs was closed because it's not part of the C2PA spec. Fair enough. If there's a better place to propose this change, please let me know.
My original post on the matter on Discord makes the pitch pretty well, I think: