Skip to content

Bump v1.1.13 — fix preview contact geometry and improve satellite/hybrid map rendering#6

Merged
c0d3rb4b4 merged 1 commit into
mainfrom
codex/enhance-preview-accuracy-and-fix-map-loading
Feb 22, 2026
Merged

Bump v1.1.13 — fix preview contact geometry and improve satellite/hybrid map rendering#6
c0d3rb4b4 merged 1 commit into
mainfrom
codex/enhance-preview-accuracy-and-fix-map-loading

Conversation

@c0d3rb4b4
Copy link
Copy Markdown
Owner

Motivation

  • Ensure preview contact points remain geometrically correct when the moon track has a non-zero closest-approach offset so C1/C2/C3/C4 maintain tangency behavior.
  • Improve readability of satellite/hybrid map modes where dense eclipse overlays or stale tiles on Android made imagery difficult to inspect.
  • Publish the mobile package increment and document the change in the CHANGELOG.md.

Description

  • Preview geometry: updated buildMotionAnchors to accept moonClosestOffset and compute axis distances from radial touch offsets, and wired the value through from calculatePreviewMoonGeometry so interpolated offsets account for closest-approach offsets (apps/mobile/src/utils/previewGeometry.ts).
  • Map UI: force MapView remount on map-type changes via a key derived from timer.mapType, enabled detail layers (showsBuildings, showsIndoors, showsPointsOfInterest, showsCompass), and reduced overlay fill opacity when mapType is satellite/hybrid; added mapTypeLabel helper, an in-map hint for photo map modes, and supporting styles and legend swatch color adjustments (apps/mobile/src/screens/TimerScreen.tsx).
  • Packaging and docs: bumped apps/mobile/package.json to 1.1.13 and added a 1.1.13 entry to CHANGELOG.md describing the fixes and tests.
  • Tests: added a regression test that verifies C1/C4 remain exact tangency points for a partial-eclipse preview with non-zero closest approach (apps/mobile/tests/preview-geometry.test.ts).

Testing

  • Ran unit tests with pnpm -C apps/mobile test -- preview-geometry.test.ts and all tests passed (7 tests, 1 file).
  • Ran TypeScript checks with pnpm -C apps/mobile typecheck and the typecheck succeeded.
  • Attempted an automated Playwright screenshot of the running dev server but the local server at http://localhost:8081 returned ERR_EMPTY_RESPONSE, so the UI screenshot step failed in this environment.

Codex Task

@c0d3rb4b4 c0d3rb4b4 merged commit 1c04cb1 into main Feb 22, 2026
1 check passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cd9d2bd70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +141 to +142
const externalTouchOffset = axisDistanceForTouchOffset(sunRadius + moonRadius);
const internalTouchOffset = axisDistanceForTouchOffset(Math.abs(sunRadius - moonRadius));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve motion anchors for non-eclipse previews

For kindAtLocation: "none", determineApproachOffset yields a moonClosestOffset larger than sunRadius + moonRadius, so axisDistanceForTouchOffset(...) collapses to 0 here; that makes both endpoint anchors offsetX = 0, and interpolateOffsetX returns a constant value for all progress values. In practice, no-eclipse previews now show a stationary moon instead of a pass-by track, which is a user-visible regression for locations where no contact occurs.

Useful? React with 👍 / 👎.

@c0d3rb4b4 c0d3rb4b4 deleted the codex/enhance-preview-accuracy-and-fix-map-loading branch February 26, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant