Bump v1.1.13 — fix preview contact geometry and improve satellite/hybrid map rendering#6
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cd9d2bd70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const externalTouchOffset = axisDistanceForTouchOffset(sunRadius + moonRadius); | ||
| const internalTouchOffset = axisDistanceForTouchOffset(Math.abs(sunRadius - moonRadius)); |
There was a problem hiding this comment.
Preserve motion anchors for non-eclipse previews
For kindAtLocation: "none", determineApproachOffset yields a moonClosestOffset larger than sunRadius + moonRadius, so axisDistanceForTouchOffset(...) collapses to 0 here; that makes both endpoint anchors offsetX = 0, and interpolateOffsetX returns a constant value for all progress values. In practice, no-eclipse previews now show a stationary moon instead of a pass-by track, which is a user-visible regression for locations where no contact occurs.
Useful? React with 👍 / 👎.
Motivation
CHANGELOG.md.Description
buildMotionAnchorsto acceptmoonClosestOffsetand compute axis distances from radial touch offsets, and wired the value through fromcalculatePreviewMoonGeometryso interpolated offsets account for closest-approach offsets (apps/mobile/src/utils/previewGeometry.ts).MapViewremount on map-type changes via akeyderived fromtimer.mapType, enabled detail layers (showsBuildings,showsIndoors,showsPointsOfInterest,showsCompass), and reduced overlay fill opacity whenmapTypeissatellite/hybrid; addedmapTypeLabelhelper, an in-map hint for photo map modes, and supporting styles and legend swatch color adjustments (apps/mobile/src/screens/TimerScreen.tsx).apps/mobile/package.jsonto1.1.13and added a1.1.13entry toCHANGELOG.mddescribing the fixes and tests.apps/mobile/tests/preview-geometry.test.ts).Testing
pnpm -C apps/mobile test -- preview-geometry.test.tsand all tests passed (7 tests, 1 file).pnpm -C apps/mobile typecheckand the typecheck succeeded.http://localhost:8081returnedERR_EMPTY_RESPONSE, so the UI screenshot step failed in this environment.Codex Task