Skip to content

fix lambda permission naming conflict #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshgubler merged 1 commit into from
Jan 21, 2026
Merged

fix lambda permission naming conflict #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Also Note: CodePipeline and CodeDeploy cannot be used together to deploy a Lambd
For a Zip file lambda
```hcl
module "lambda_api" {
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.0"
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.1"
app_name = "my-lambda-codedeploy-dev"
zip_filename = "./src/lambda.zip"
zip_handler = "index.handler"
Expand All @@ -50,7 +50,7 @@ module "lambda_api" {
For a docker image lambda:
```hcl
module "lambda_api" {
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.0"
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.1"
app_name = "my-docker-lambda"
image_uri = "my-image-from-my-ecr:latest"
hosted_zone = module.acs.route53_zone
Expand Down
2 changes: 1 addition & 1 deletion examples/docker-lambda/docker.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module "acs" {

module "lambda_api" {
# source = "../../"
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.0"
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.1"
app_name = "my-docker-lambda"
image_uri = "my-image-from-my-ecr:latest"
hosted_zone = module.acs.route53_zone
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-lambda-in-vpc/example.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module "acs" {

module "lambda_api" {
# source = "../../"
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.0"
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v4.1.1"
app_name = "my-lambda-dev"
zip_filename = "./src/lambda.zip"
zip_handler = "index.handler"
Expand Down
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ resource "aws_lambda_permission" "with_lb" {

resource "aws_lambda_permission" "with_tst_lb" {
count = local.use_codedeploy ? 1 : 0
statement_id = "AllowExecutionFromlb"
statement_id = "AllowExecutionFromTstlb"
action = "lambda:InvokeFunction"
function_name = local.use_zip ? aws_lambda_function.zip_api[0].function_name : aws_lambda_function.docker_api[0].function_name
principal = "elasticloadbalancing.amazonaws.com"
Expand Down
Loading