Add rollup optimized for HashAggregation#122
Open
wenjiecn wants to merge 14 commits intobytedance:mainfrom
Open
Add rollup optimized for HashAggregation#122wenjiecn wants to merge 14 commits intobytedance:mainfrom
wenjiecn wants to merge 14 commits intobytedance:mainfrom
Conversation
yangzhg
reviewed
Jan 19, 2026
yangzhg
reviewed
Jan 19, 2026
Co-authored-by: Zhengguo Yang <yangzhgg@gmail.com>
kexianda
reviewed
Feb 25, 2026
Author
Co-authored-by: Lu Niu <lniu@pinterest.com>
…tedance#268) Co-authored-by: zhli1142015 <zhli@microsoft.com>
Co-authored-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
bytedance#269) Co-authored-by: zhli1142015 <zhli@microsoft.com>
906a3a9 to
b88fc0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #121
Type of Change
Description
Create an aggNode in the intermediate phase in the agg operator, and use the aggNode to create three Intermediate groupingSet operators to process group data of groups 1 to 3. The original partial groupingSet operator processes data in group 0.
The total data input is reduced to reduce the HashTable operation time, which is optimized in the rollup scenario.
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
TPCDS99 1T results in velox.
q22
Before: 13.686s
After: 11.256s (+17.76%)
q67
Before: 152.416s
After: 136.983 (+10.13%)
```
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes