chore(ci): Use pre-commit checks in CI#120
Merged
ZacBlanco merged 15 commits intobytedance:mainfrom Jan 27, 2026
Merged
Conversation
7939e11 to
ad0409a
Compare
bda35a5 to
f0434d4
Compare
65ced6c to
7abdc46
Compare
yangzhg
reviewed
Jan 21, 2026
d6a597d to
a479107
Compare
Collaborator
Author
|
@yangzhg thanks for your previous comments and improvements by creating |
yangzhg
reviewed
Jan 26, 2026
yangzhg
reviewed
Jan 26, 2026
Collaborator
|
LGTM with a little comments. |
This is better for maintainability as you don't need to edit the pre-commit-config AND the github workflow. Better to just keep it all in one place.
2f3e6f5 to
4a308ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Use pre-commit checks as CI jobs to prevent relying on pre-commit checks locally. There have already been some PRs which break the formatting rules in the pre-commit checks introduced by #113
Type of Change
Description
Removes the individual clang-format and license-check workflows in favor of just calling
pre-commit run --all-filesto verify all pre-commit checks succeed in the codebase. This prevents needing to maintain multiple workflows for the new checks separate from ourpre-commit-config.yamland also ensures that all new changes follow thepre-commitguidelines defined in the config.Performance Impact
Release Note
N/A
Checklist (For Author)
Breaking Changes