fix: #179,fix double free uv_handle#183
Closed
thesues wants to merge 2 commits intobytedance:mainfrom
Closed
Conversation
tchaikov
reviewed
Jun 4, 2025
src/infinistore.cpp
Outdated
| delete client; | ||
|
|
||
| if (client) { | ||
| client->handle_ = NULL; |
There was a problem hiding this comment.
what's the point of assigning a member variable right before delete ing its enclosing instance?
Collaborator
Author
There was a problem hiding this comment.
handle_ in Client works like a weak_ptr. this line is to make sure ~Client() will never delete handle_. But this patch has no different from before. #179 is very hard to reproduce. Use this PR as a placeholder.
There was a problem hiding this comment.
i see. thanks. just a nit, might want to use nullptr in lieu of NULL in modern C++ code.
hhzguo
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.