Skip to content

fix: #179,fix double free uv_handle#182

Closed
thesues wants to merge 1 commit intobytedance:mainfrom
thesues:fix-crash
Closed

fix: #179,fix double free uv_handle#182
thesues wants to merge 1 commit intobytedance:mainfrom
thesues:fix-crash

Conversation

@thesues
Copy link
Collaborator

@thesues thesues commented May 27, 2025

No description provided.

@thesues thesues requested a review from Copilot May 27, 2025 21:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a double free issue related to uv_handle and improves the memory cleanup for outstanding RDMA operations.

  • Removed manual freeing of handle_ to avoid double free errors.
  • Added a loop to properly delete dynamically allocated RDMA operation arrays.
Comments suppressed due to low confidence (2)

src/infinistore.cpp:119

  • Ensure that removing the manual free for handle_ is safe and that its resource is properly released elsewhere to avoid potential memory leaks.
if (handle_) { free(handle_); handle_ = NULL; }

src/infinistore.cpp:153

  • Confirm that the arrays pointed to by item.first and item.second are allocated using new[] to ensure that delete[] is the correct deallocation method.
while (!outstanding_rdma_ops_queue_.empty()) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants