Merged
Conversation
Collaborator
thesues
commented
May 14, 2025
thesues
commented
- use meson to build extension
- add pyproject.toml
There was a problem hiding this comment.
Pull Request Overview
This PR removes the old Makefile‐based build system and auto‐generated FlatBuffers headers in favor of using Meson with Ninja and a modern pyproject.toml for building a Python extension. Key changes include:
- Eliminating multiple auto‐generated FlatBuffers header files and the Makefile.
- Adding a Meson build configuration and updating setup.py to invoke meson & ninja.
- Updating packaging and build scripts (pyproject.toml, build_manylinux_wheels.sh, and README.md) to reflect the new build process.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tcp_payload_request_generated.h | Removed autogenerated header |
| src/meta_request_generated.h | Removed autogenerated header |
| src/meta_request.fbs | Minor update (newline) before root_type |
| src/meson.build | New Meson build configuration for the C++ extension |
| src/local_meta_generated.h | Removed autogenerated header |
| src/get_match_last_index_generated.h | Removed autogenerated header |
| src/delete_keys_generated.h | Removed autogenerated header |
| src/allocate_response_generated.h | Removed autogenerated header |
| src/Makefile | Removed Makefile |
| setup.py | Updated to use Meson/Ninja for building and copied shared libraries |
| pyproject.toml | Added build system configuration |
| build_manylinux_wheels.sh | Updated build script with Meson integration |
| README.md | Updated installation instructions for development |
| Dockerfile.build | Removed legacy Python-specific pybind11 installation steps |
Comments suppressed due to low confidence (1)
README.md:36
- [nitpick] Consider revising the heading for clarity (e.g., 'Development Installation') to better reflect the intended audience.
## Install from Source Code for develop
lyppg
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.