Skip to content

Cranelift: add bitops simplification rules #12738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Mar 9, 2026
Merged

Cranelift: add bitops simplification rules #12738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions cranelift/codegen/src/opts/bitops.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,3 +251,41 @@
(rule (simplify (band ty x (bor ty x y))) x)
(rule (simplify (band ty (bor ty y x) x)) x)
(rule (simplify (band ty x (bor ty y x))) x)

; (x | z) & (y | z) --> (x & y) | z
(rule (simplify (band ty (bor ty x z) (bor ty y z))) (bor ty (band ty x y) z))
(rule (simplify (band ty (bor ty y z) (bor ty x z))) (bor ty (band ty x y) z))
(rule (simplify (band ty (bor ty x z) (bor ty z y))) (bor ty (band ty x y) z))
(rule (simplify (band ty (bor ty z y) (bor ty x z))) (bor ty (band ty x y) z))
(rule (simplify (band ty (bor ty z x) (bor ty y z))) (bor ty (band ty x y) z))
(rule (simplify (band ty (bor ty y z) (bor ty z x))) (bor ty (band ty x y) z))
(rule (simplify (band ty (bor ty z x) (bor ty z y))) (bor ty (band ty x y) z))
(rule (simplify (band ty (bor ty z y) (bor ty z x))) (bor ty (band ty x y) z))

; (x & z) | (y & z) --> (x | y) & z
(rule (simplify (bor ty (band ty x z) (band ty y z))) (band ty (bor ty x y) z))
(rule (simplify (bor ty (band ty y z) (band ty x z))) (band ty (bor ty x y) z))
(rule (simplify (bor ty (band ty x z) (band ty z y))) (band ty (bor ty x y) z))
(rule (simplify (bor ty (band ty z y) (band ty x z))) (band ty (bor ty x y) z))
(rule (simplify (bor ty (band ty z x) (band ty y z))) (band ty (bor ty x y) z))
(rule (simplify (bor ty (band ty y z) (band ty z x))) (band ty (bor ty x y) z))
(rule (simplify (bor ty (band ty z x) (band ty z y))) (band ty (bor ty x y) z))
(rule (simplify (bor ty (band ty z y) (band ty z x))) (band ty (bor ty x y) z))

; (x | y) ^ (x | ~y) --> ~x
(rule (simplify (bxor ty (bor ty x y) (bor ty x (bnot ty y)))) (bnot ty x))
(rule (simplify (bxor ty (bor ty x (bnot ty y)) (bor ty x y))) (bnot ty x))
(rule (simplify (bxor ty (bor ty x y) (bor ty (bnot ty y) x))) (bnot ty x))
(rule (simplify (bxor ty (bor ty (bnot ty y) x) (bor ty x y))) (bnot ty x))
(rule (simplify (bxor ty (bor ty y x) (bor ty x (bnot ty y)))) (bnot ty x))
(rule (simplify (bxor ty (bor ty x (bnot ty y)) (bor ty y x))) (bnot ty x))
(rule (simplify (bxor ty (bor ty y x) (bor ty (bnot ty y) x))) (bnot ty x))
(rule (simplify (bxor ty (bor ty (bnot ty y) x) (bor ty y x))) (bnot ty x))

; (~x) & (~y) --> ~(x | y)
(rule (simplify (band ty (bnot ty x) (bnot ty y))) (bnot ty (bor ty x y)))
(rule (simplify (band ty (bnot ty y) (bnot ty x))) (bnot ty (bor ty x y)))

; (~x) | (~y) --> ~(x & y)
(rule (simplify (bor ty (bnot ty x) (bnot ty y))) (bnot ty (band ty x y)))
(rule (simplify (bor ty (bnot ty y) (bnot ty x))) (bnot ty (band ty x y)))
83 changes: 82 additions & 1 deletion cranelift/filetests/filetests/egraph/fold-bitops.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,85 @@ block0(v0: i32, v1: i32):
; function %test_band_bor_absorb_x(i32, i32) -> i32 fast {
; block0(v0: i32, v1: i32):
; return v0
; }
; }

;; (band ty (bor ty x z) (bor ty y z)) -> (bor ty (band ty x y) z)
function %test_band_bor_bor(i32, i32, i32) -> i32 fast {
block0(v0: i32, v1: i32, v2: i32):
v3 = bor v0, v2
v4 = bor v1, v2
v5 = band v3, v4
return v5
}

; function %test_band_bor_bor(i32, i32, i32) -> i32 fast {
; block0(v0: i32, v1: i32, v2: i32):
; v8 = band v1, v0
; v9 = bor v8, v2
; return v9
; }

;; (bor ty (band ty x z) (band ty y z)) -> (band ty (bor ty x y) z)
function %test_bor_band_band(i32, i32, i32) -> i32 fast {
block0(v0: i32, v1: i32, v2: i32):
v3 = band v0, v2
v4 = band v1, v2
v5 = bor v3, v4
return v5
}

; function %test_bor_band_band(i32, i32, i32) -> i32 fast {
; block0(v0: i32, v1: i32, v2: i32):
; v8 = bor v1, v0
; v9 = band v8, v2
; return v9
; }

;; (bxor ty (bor ty x y) (bor ty x (bnot ty y))) -> (bnot ty x)
function %test_bxor_bor_bor_bnot(i32, i32) -> i32 fast {
block0(v0: i32, v1: i32):
v2 = bor v0, v1
v3 = bnot v1
v4 = bor v0, v3
v5 = bxor v2, v4
return v5
}

; function %test_bxor_bor_bor_bnot(i32, i32) -> i32 fast {
; block0(v0: i32, v1: i32):
; v6 = bnot v0
; return v6
; }

;; (band ty (bnot ty x) (bnot ty y)) -> (bnot ty (bor ty x y))
function %test_band_bnot_bnot(i32, i32) -> i32 fast {
block0(v0: i32, v1: i32):
v2 = bnot v0
v3 = bnot v1
v4 = band v2, v3
return v4
}

; function %test_band_bnot_bnot(i32, i32) -> i32 fast {
; block0(v0: i32, v1: i32):
; v7 = bor v1, v0
; v8 = bnot v7
; return v8
; }

;; (bor ty (bnot ty x) (bnot ty y)) -> (bnot ty (band ty x y))
function %test_bor_bnot_bnot(i32, i32) -> i32 fast {
block0(v0: i32, v1: i32):
v2 = bnot v0
v3 = bnot v1
v4 = bor v2, v3
return v4
}

; function %test_bor_bnot_bnot(i32, i32) -> i32 fast {
; block0(v0: i32, v1: i32):
; v7 = band v1, v0
; v8 = bnot v7
; return v8
; }

68 changes: 67 additions & 1 deletion cranelift/filetests/filetests/runtests/bitops.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,4 +270,70 @@ block0(v0: i32, v1: i32):
; run: %test_band_bor_absorb_x(1, 0) == 1
; run: %test_band_bor_absorb_x(1, 1) == 1
; run: %test_band_bor_absorb_x(2, 1) == 2
; run: %test_band_bor_absorb_x(0xf0f0f0f0, 0x0f0f0f0f) == 0xf0f0f0f0
; run: %test_band_bor_absorb_x(0xf0f0f0f0, 0x0f0f0f0f) == 0xf0f0f0f0

function %test_band_bor_bor(i32, i32, i32) -> i32 fast {
block0(v0: i32, v1: i32, v2: i32):
v3 = bor v0, v2
v4 = bor v1, v2
v5 = band v3, v4
return v5
}

; run: %test_band_bor_bor(0, 0, 0) == 0
; run: %test_band_bor_bor(1, 0, 0) == 0
; run: %test_band_bor_bor(1, 0, 1) == 1

function %test_bor_band_band(i32, i32, i32) -> i32 fast {
block0(v0: i32, v1: i32, v2: i32):
v3 = band v0, v2
v4 = band v1, v2
v5 = bor v3, v4
return v5
}

; run: %test_bor_band_band(0, 0, 0) == 0
; run: %test_bor_band_band(1, 0, 0) == 0
; run: %test_bor_band_band(1, 0, 1) == 1
; run: %test_bor_band_band(2, 1, 1) == 1
; run: %test_bor_band_band(0xf0, 0x0f, 0xaa) == 0xaa

function %test_bxor_bor_bor_bnot(i32, i32) -> i32 fast {
block0(v0: i32, v1: i32):
v2 = bor v0, v1
v3 = bnot v1
v4 = bor v0, v3
v5 = bxor v2, v4
return v5
}

; run: %test_bxor_bor_bor_bnot(0, 0) == 0xffffffff
; run: %test_bxor_bor_bor_bnot(1, 0) == 0xfffffffe
; run: %test_bxor_bor_bor_bnot(1, 1) == 0xfffffffe
; run: %test_bxor_bor_bor_bnot(0x12345678, 0x9abcdef0) == 0xedcba987
; run: %test_bxor_bor_bor_bnot(0xffffffff, 0) == 0


function %test_band_bnot_bnot(i32, i32) -> i32 fast {
block0(v0: i32, v1: i32):
v2 = bnot v0
v3 = bnot v1
v4 = band v2, v3
return v4
}

; run: %test_band_bnot_bnot(0, 0) == 0xffffffff
; run: %test_band_bnot_bnot(1, 0) == 0xfffffffe
; run: %test_band_bnot_bnot(1, 1) == 0xfffffffe

function %test_bor_bnot_bnot(i32, i32) -> i32 fast {
block0(v0: i32, v1: i32):
v2 = bnot v0
v3 = bnot v1
v4 = bor v2, v3
return v4
}

; run: %test_bor_bnot_bnot(0, 0) == 0xffffffff
; run: %test_bor_bnot_bnot(1, 0) == 0xffffffff
; run: %test_bor_bnot_bnot(1, 1) == 0xfffffffe
Loading