4554 - skills fixes#5095
Open
marko-kriskovic wants to merge 44 commits into
Open
Conversation
Fixes three review comments from copilot-pull-request-reviewer on PR #5077: 1. TriggerDefinitionServiceImpl: the previous loop checked records.size() only at loop-entry, so a runaway initial response or an addAll of a large page could push the accumulator past MAX_POLLING_TRIGGER_RECORDS and defeat the heap-safety goal. Extract appendCapped(...) that truncates each append to the remaining headroom, and apply it to both the initial pollOutput and every subsequent page. Track whether truncation occurred and use it (in addition to pollImmediately) as the WARN trigger so silent data loss can no longer pass unannounced. 2. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxIterations: replace the loose <= 200 bound with <= 101 (the exact production maximum: 100 in-loop iterations + 1 initial poll) so off-by-one regressions fail. 3. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxRecords: replace the loose <= 20_000 bound with <= 10_000 (the actual record cap) so a record-cap overshoot can no longer slip past the test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…y to test implemented file components
…til output stream closes - relying to thread was reason of flakiness
…d width - added a tooltip to show the full name when it's truncated (logic is if it's longer than 32 characters)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist: