Conversation
Contributor
ivicac
commented
May 23, 2026
ivicac
commented
- 5076 Cap polling-trigger poll loop to prevent OutOfMemoryError
- 5076 Cap default Caffeine cache spec with maximumSize to bound heap
- 5076 Log a warning when a polling-trigger safety cap trips
Closed
ivicac
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds guardrails to prevent runaway in-memory growth by (1) bounding polling-trigger “poll immediately” pagination loops and (2) adding a default maximum size to the Caffeine cache configuration, with tests to validate the behavior and a WARN log when the polling cap is hit.
Changes:
- Add safety caps for polling-trigger pagination (max iterations + max records) and log a WARN when the cap trips.
- Add unit tests covering capped polling behavior and cap-trip logging.
- Cap the default Caffeine cache builder with
maximumSize(1_000)to bound heap usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
server/libs/platform/platform-component/platform-component-service/src/main/java/com/bytechef/platform/component/service/TriggerDefinitionServiceImpl.java |
Adds polling-loop safety caps and WARN logging when a cap is hit. |
server/libs/platform/platform-component/platform-component-service/src/test/java/com/bytechef/platform/component/service/TriggerDefinitionServiceTest.java |
Adds tests for bounded polling behavior and cap-trip warning logging. |
server/libs/config/cache-config/src/main/java/com/bytechef/cache/config/CacheConfiguration.java |
Adds a default maximumSize to the Caffeine cache builder to bound cache growth. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes three review comments from copilot-pull-request-reviewer on PR #5077: 1. TriggerDefinitionServiceImpl: the previous loop checked records.size() only at loop-entry, so a runaway initial response or an addAll of a large page could push the accumulator past MAX_POLLING_TRIGGER_RECORDS and defeat the heap-safety goal. Extract appendCapped(...) that truncates each append to the remaining headroom, and apply it to both the initial pollOutput and every subsequent page. Track whether truncation occurred and use it (in addition to pollImmediately) as the WARN trigger so silent data loss can no longer pass unannounced. 2. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxIterations: replace the loose <= 200 bound with <= 101 (the exact production maximum: 100 in-loop iterations + 1 initial poll) so off-by-one regressions fail. 3. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxRecords: replace the loose <= 20_000 bound with <= 10_000 (the actual record cap) so a record-cap overshoot can no longer slip past the test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ivicac
added a commit
to ivicac/bytechef
that referenced
this pull request
May 24, 2026
Fixes three review comments from copilot-pull-request-reviewer on PR bytechefhq#5077: 1. TriggerDefinitionServiceImpl: the previous loop checked records.size() only at loop-entry, so a runaway initial response or an addAll of a large page could push the accumulator past MAX_POLLING_TRIGGER_RECORDS and defeat the heap-safety goal. Extract appendCapped(...) that truncates each append to the remaining headroom, and apply it to both the initial pollOutput and every subsequent page. Track whether truncation occurred and use it (in addition to pollImmediately) as the WARN trigger so silent data loss can no longer pass unannounced. 2. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxIterations: replace the loose <= 200 bound with <= 101 (the exact production maximum: 100 in-loop iterations + 1 initial poll) so off-by-one regressions fail. 3. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxRecords: replace the loose <= 20_000 bound with <= 10_000 (the actual record cap) so a record-cap overshoot can no longer slip past the test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
igorbeslic
requested changes
May 24, 2026
ivicac
added a commit
to ivicac/bytechef
that referenced
this pull request
May 24, 2026
Fixes three review comments from copilot-pull-request-reviewer on PR bytechefhq#5077: 1. TriggerDefinitionServiceImpl: the previous loop checked records.size() only at loop-entry, so a runaway initial response or an addAll of a large page could push the accumulator past MAX_POLLING_TRIGGER_RECORDS and defeat the heap-safety goal. Extract appendCapped(...) that truncates each append to the remaining headroom, and apply it to both the initial pollOutput and every subsequent page. Track whether truncation occurred and use it (in addition to pollImmediately) as the WARN trigger so silent data loss can no longer pass unannounced. 2. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxIterations: replace the loose <= 200 bound with <= 101 (the exact production maximum: 100 in-loop iterations + 1 initial poll) so off-by-one regressions fail. 3. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxRecords: replace the loose <= 20_000 bound with <= 10_000 (the actual record cap) so a record-cap overshoot can no longer slip past the test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
igorbeslic
pushed a commit
that referenced
this pull request
May 26, 2026
Fixes three review comments from copilot-pull-request-reviewer on PR #5077: 1. TriggerDefinitionServiceImpl: the previous loop checked records.size() only at loop-entry, so a runaway initial response or an addAll of a large page could push the accumulator past MAX_POLLING_TRIGGER_RECORDS and defeat the heap-safety goal. Extract appendCapped(...) that truncates each append to the remaining headroom, and apply it to both the initial pollOutput and every subsequent page. Track whether truncation occurred and use it (in addition to pollImmediately) as the WARN trigger so silent data loss can no longer pass unannounced. 2. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxIterations: replace the loose <= 200 bound with <= 101 (the exact production maximum: 100 in-loop iterations + 1 initial poll) so off-by-one regressions fail. 3. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxRecords: replace the loose <= 20_000 bound with <= 10_000 (the actual record cap) so a record-cap overshoot can no longer slip past the test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
marko-kriskovic
pushed a commit
that referenced
this pull request
May 29, 2026
Fixes three review comments from copilot-pull-request-reviewer on PR #5077: 1. TriggerDefinitionServiceImpl: the previous loop checked records.size() only at loop-entry, so a runaway initial response or an addAll of a large page could push the accumulator past MAX_POLLING_TRIGGER_RECORDS and defeat the heap-safety goal. Extract appendCapped(...) that truncates each append to the remaining headroom, and apply it to both the initial pollOutput and every subsequent page. Track whether truncation occurred and use it (in addition to pollImmediately) as the WARN trigger so silent data loss can no longer pass unannounced. 2. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxIterations: replace the loose <= 200 bound with <= 101 (the exact production maximum: 100 in-loop iterations + 1 initial poll) so off-by-one regressions fail. 3. TriggerDefinitionServiceTest.testExecutePollingTriggerStopsAfterMaxRecords: replace the loose <= 20_000 bound with <= 10_000 (the actual record cap) so a record-cap overshoot can no longer slip past the test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.