Skip to content

mci 0 will result a out-of-memory by div 10 always true #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dindinw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

mci 0 will result a out-of-memory by div 10 always true #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3438b1b
mci 0 will result a out-of-memory by div 10 always true
Aug 20, 2017
1f62efb
small code change to handle mci=0 after code review
Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions main_chain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,8 @@ function markMcIndexStable(conn, mci, onDone){
// returns list of past MC indices for skiplist
function getSimilarMcis(mci){
Copy link

@katringoogoo katringoogoo Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dindinw what do you think of rewriting the whole function as

 function getSimilarMcis(mci){
  	var arrSimilarMcis = [];
  	if (mci <= 0)
  	  	return arrSimilarMcis;
  	var divisor = 10;
  	while (mci % divisor === 0) {
  		arrSimilarMcis.push(mci - divisor);
 		divisor *= 10;
 	}
 	return arrSimilarMcis;
 }

Copy link
Author

@dindinw dindinw Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your code is better 👍

var arrSimilarMcis = [];
if (mci <= 0)
return arrSimilarMcis;
var divisor = 10;
while (true){
if (mci % divisor === 0){
Expand Down