Optimize clear() method in RedisCacheEngine and add Docker config
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed performance; add Docker service run configuration for tests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Psr16/RedisCacheEngine.php
Dismissed
| $this->delete($matches['key']); | ||
| $iterator = null; | ||
| do { | ||
| $keys = $this->redis->scan($iterator, 'cache:*'); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
Owner
Author
There was a problem hiding this comment.
I need to create a variable iterator because it gets the references for the next part, if available.
The signature of scan method is:
scan(null|int|string $iterator, string|null $pattern = null, int $count = 0, string|null $type = null)
With is perfectly acceptable set null in $iterator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
clear()method inRedisCacheEngineby using the SCAN command for improved performance.Why is this necessary?
clear()operation in the Redis Cache Engine.Unit tests
Integration tests
Documentation